Ami creation #21
Merged
Ami creation #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
May 20, 2016 10:35
|
@hazim1093 plz review this PR and merge it! |
| @@ -83,6 +84,9 @@ destroy_all: \ | |||
| destroy_gocd \ | |||
| destroy_elk \ | |||
| destroy_worker \ | |||
| destroy_application \ | |||
| destroy_snapshot \ | |||
| destroy_amicreation \ | |||
There was a problem hiding this comment.
@hazim1093 how about renaming the module to "amicreator" or "animator" or "baker" etc.
|
@hazim1093 plz add some description to the new added modules which explains what it does and what is the purpose of it |
|
@rasheedamir |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.