This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
[WIP][Core][Wallet] Sync improvements #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't connect to chain No code review done yet |
added 4 commits
August 16, 2020 18:23
This is a very intensive check which is hardly used in SCC and can safely be replaced with lightweight, height-based enforcements instead of softforks.
This commit will stop the wallet model from polling for balance changes on new blocks when the blocks have a timestamp older than the earliest key the wallet generated, saving a very large amount of resources for syncs from scratch.
JSKitty
force-pushed
the
sync_improvements
branch
from
623eca0 to
80aeccf
Compare
Block 199 was the last black that did not have a serialized height within the coinbase, so the BlockV2 check is only enabled on, and after, block 200
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports a bunch of small but effective amount of improvements to the syncing process of SCC, most of these changes are from ZENZO and upstream PIVX, adapted to work with SCC's slightly-older codebase.
No in-depth tests have been ran on this PR yet, nor benchmarks, but this is critical to ensuring the PR works as intended and so that we can find a readable statistic (E.G: Percentage difference) of the syncing speed between SCC v2.0.2 and this PR.
Code reviews and tests appreciated!
Work-In-Progress; Please do NOT merge yet!