Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KO Classic Phonemizers] Apply Korean sandhi rules to Classic phonemizers #1212

Merged
merged 12 commits into from
Aug 4, 2024

Conversation

lottev1991
Copy link
Contributor

With this PR, the Korean UTAU phonemizers will apply Korean sandhi rules to Hangeul lyrics. Some of the classic phonemizers already have the sandhi rules applied properly with KoreanPhonemizerUtil, so these are not affected.

Affected phonemizers:

  • KO VCV;
  • KO CVCCV;
  • KO CVC (I think some of the old code could be deleted, but I haven't yet properly looked into that, because I'm afraid of breaking things. I might one day);
  • KO to JA.

@lottev1991
Copy link
Contributor Author

lottev1991 commented Jul 10, 2024

Apologies for the failing checks, I got this error:

Determining projects to restore...
/home/runner/work/OpenUtau/OpenUtau/OpenUtau/OpenUtau.csproj : error NU1903: Warning As Error: Package 'System.Text.Json' 7.0.2 has a known high severity vulnerability, https://github.com/advisories/GHSA-hh2w-p6rv-4g7w
  Restored /home/runner/work/OpenUtau/OpenUtau/OpenUtau.Core/OpenUtau.Core.csproj (in 9.94 sec).
  Restored /home/runner/work/OpenUtau/OpenUtau/OpenUtau.Plugin.Builtin/OpenUtau.Plugin.Builtin.csproj (in 9.94 sec).
  Failed to restore /home/runner/work/OpenUtau/OpenUtau/OpenUtau/OpenUtau.csproj (in 9.97 sec).
Error: Process completed with exit code 1.

Is there anything I can do about that, or that can be done about it? I'm kinda lost here... I keep rerunning checks but it doesn't seem to be working.

@oxygen-dioxide
Copy link
Contributor

Please sync the latest code from stakira/OpenUtau to your fork, and the tests will pass

@stakira stakira merged commit 121872c into stakira:master Aug 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants