Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phonemizer Tests] Add alternate support #706

Closed
wants to merge 12 commits into from

Conversation

lottev1991
Copy link
Contributor

I noticed that alternate support was not in the PhonemizerTest API, so I decided to add it.
I do hope this works correctly, if not, I will try to look for a solution.

Related to #698, #699, and #700.

@lottev1991 lottev1991 marked this pull request as ready for review May 16, 2023 19:34
@stakira
Copy link
Owner

stakira commented May 21, 2023

Thanks for the goodwill, but I don't see anything getting tested. Also, I think alt should be int?. Please add tests with changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants