-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JA various phoemizers] PhoneticHint support and Unicode countermeasures #710
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c4f8de1
JA VCV &CVVC support PhoneticHint
maiko3tattun f83eb6d
JA VCV &CVVC support PhoneticHint
maiko3tattun 26c5769
Merge branch '0515_JAphonemizer' of https://github.com/maiko3tattun/O…
maiko3tattun 9b277fd
JA various phoemizers support PhoneticHint and Unicode countermeasures
maiko3tattun 5a261dd
JA VCV & CVVC support alternate
maiko3tattun 8910304
Merge branch 'stakira:master' into 0515_JAphonemizer
maiko3tattun d273f6c
Add alternate support
lottev1991 4e067dd
Add alternate strings
lottev1991 95eeb1a
Add alternate strings
lottev1991 849bc89
Add alternate strings
lottev1991 b7be167
Add alternate strings
lottev1991 c44204c
Add alternate strings
lottev1991 8ea8d13
Add alternate strings
lottev1991 4518025
Add alternate strings
lottev1991 204a8ec
Oops, accidentally put too many notes
lottev1991 a915707
Oops, accidentally put too >few< notes
lottev1991 70076bb
Yet another string error
lottev1991 e078b6d
Resolve conflicts
maiko3tattun 8007bac
Add surrogate characters tests
maiko3tattun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
ToUnicodeElements()
no longer needed? How so?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ToUnicodeElements() was only used to count characters correctly.
However, this approach does not allow が aliases to be called from か+゛.
Using Normalize() to remove surrogate characters, will allow correct character counts while resolving differences in string formatting.