Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading dialog / Set try-catch #892

Merged
merged 6 commits into from
Nov 25, 2023

Conversation

maiko3tattun
Copy link
Contributor

Improvements:

  • Show dialog when heavy processing
  • Set try-catch for some processes to avoid crashes

@maiko3tattun
Copy link
Contributor Author

bandicam.2023-10-20.23-04-47-796.mp4

@stakira
Copy link
Owner

stakira commented Nov 14, 2023

This is a nice change, but I don't think it should be done with a notification. As you have found, I'd prefer a message box modal created and destroyed locally like in RegenFrq().

@maiko3tattun
Copy link
Contributor Author

This may be called from the ViewModel, so they cannot find the parent window...

@stakira stakira merged commit f4cb188 into stakira:master Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants