Better testing for phoneme attributes in multi-phoneme notes #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test method required attributes and lyrics assigned exactly 1-to-1, but notes often contain multiple phonemes and each phoneme can have different attributes. This made it difficult to test if attributes were being handled correctly when changing alts, tone shift, or voice color.
These changes will help with implementing the feature in PR #889
New
Syllable
andEnding
, allowing these to be used as part of phonemizer logicFixed
Other additions