Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better testing for phoneme attributes in multi-phoneme notes #896

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

adlez27
Copy link
Contributor

@adlez27 adlez27 commented Oct 22, 2023

The existing test method required attributes and lyrics assigned exactly 1-to-1, but notes often contain multiple phonemes and each phoneme can have different attributes. This made it difficult to test if attributes were being handled correctly when changing alts, tone shift, or voice color.
These changes will help with implementing the feature in PR #889

New

  • SyllableBasedPhonemizer now includes phoneme attributes in Syllable and Ending, allowing these to be used as part of phonemizer logic
  • PhonemizerTestBase now includes a test method where each note can be grouped with more than 1 set of phoneme attributes
 public void RunPhonemizeTest(string singerName, NoteParams[] inputs, string[] aliases)
  • Since NoteParams also includes phonetic hint, this utility method helps with testing phonetic hint processing without needing to copy+paste the same attributes
protected PhonemeParams[] SamePhonemeParams(int count, int shift, int alt, string color)

Fixed

  • JA CVVC and JA Presamp can now apply phoneme attributes on CV and VC phonemes independently

Other additions

  • Config files in test banks for testing multipitch
  • Phonetic hint tests
  • Voice color/tone shift tests

Including fix for phoneme attributes not applying to VCs in JA CVVC and JA presamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants