Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextBox font #906

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Fix TextBox font #906

merged 2 commits into from
Nov 25, 2023

Conversation

maiko3tattun
Copy link
Contributor

The font used for the text boxes is a bit hard to read in Japanese, so changed to the same font as the text and labels.
It may depend on the environment, but it will not have any adverse effect.
This is largely a personal preference, so please merge if necessary.
image

@@ -62,7 +62,7 @@
<Setter Property="Padding" Value="4,1"/>
<Setter Property="Margin" Value="0,0,0,4"/>
<Setter Property="FontSize" Value="12"/>
<Setter Property="FontFamily" Value="{DynamicResource ui.textbox.fontfamily}"/>
<Setter Property="FontFamily" Value="{DynamicResource ui.fontfamily}"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These was for working around Avalonia 10 could not handle CJK font fallback in text boxes. You can simply delete this line and delete ui.textbox.fontfamily from Strings.axaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! updated.

@stakira stakira merged commit 6e61664 into stakira:master Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants