[SyllableBasedPhonemizer API] Make alias extension restriction to same subbank optional #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lottev1991
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that aliases can now also be extended across different subbanks in syllable-based phonemizers. Note that the option to restrict it to only the same subbank has not been removed; I've simply made it so that it will be up to the phonemizer developers to decide.
The reason I am making this PR is because the current spec can cause issues when extending diphthongs in certain languages (including English) across different pitches and/or voice colors.
In order to re-implement the previous spec into a phonemizer, the code should look something like this:
or, in negative form: