Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ENUNUKoreanPhonemizer #994

Merged
merged 10 commits into from
Jan 25, 2024
Merged

Add ENUNUKoreanPhonemizer #994

merged 10 commits into from
Jan 25, 2024

Conversation

EX3exp
Copy link
Contributor

@EX3exp EX3exp commented Dec 27, 2023 •
edited
Loading

  • Supports Korean Phoneme Variation, User-defined phoneme(jamo) dictionary by jamo_dict.yaml , and Two types of semivowel notation("g y a" for "갸", or "gy a" for "갸") by ko-ENUNU.ini.
  • This is Branch after (Should be merged after) Add DiffSingerKoreanPhonemizer #993

@EX3exp EX3exp marked this pull request as ready for review December 28, 2023 15:55
@EX3exp EX3exp marked this pull request as draft January 15, 2024 04:42
@EX3exp EX3exp marked this pull request as ready for review January 16, 2024 11:42
@EX3exp
Copy link
Contributor Author

EX3exp commented Jan 16, 2024

I finished and tested #989➡️#990➡️#991➡️#992➡️#993➡️#994 now, and it seems there's no specific bugs...
Could you merge it? 👀

@stakira stakira merged commit 453f300 into stakira:master Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EX3exp @stakira