afup#1437 fix tests

.env.dist

@@ -66,8 +66,8 @@ PAYBOX_IDENTIFIANT=110647233
 BLOG_API_KEY=123456
 
 SMTP_HOST="localhost"
-SMTP_PORT="1025"
-SMTP_TLS="0"
+SMTP_PORT=1025
+SMTP_TLS=0
 SMTP_USERNAME=""
 SMTP_PASSWORD=""
 MAILER_FORCE_RECIPIENTS=""

dependencies/magpierss/extlib/Snoopy.class.inc

@@ -645,7 +645,7 @@ class Snoopy
             $cmdline_params .= " -m " . $this->read_timeout;
         }
 
-        $headerfile = uniqid(time());
+        $headerfile = uniqid((string) time(), true);
 
         # accept self-signed certs
         $cmdline_params .= " -k";
@@ -857,7 +857,7 @@ class Snoopy
                 break;
 
             case "multipart/form-data":
-                $this->_mime_boundary = "Snoopy" . md5(uniqid(microtime()));
+                $this->_mime_boundary = "Snoopy" . md5(uniqid((string) microtime()));
 
                 reset($formvars);
 

sources/AppBundle/Association/Model/User.php

@@ -582,7 +582,7 @@ public function getLastSubscription()
     public function setLastSubscription($sub)
     {
         if ($sub !== null) {
-            $this->lastSubscription = \DateTimeImmutable::createFromFormat('U', $sub);
+            $this->lastSubscription = \DateTimeImmutable::createFromFormat('U', (string)$sub);
         }
     }
 

sources/AppBundle/Association/UserMembership/UserService.php

@@ -41,7 +41,7 @@ public function __construct(
 
     public function generateRandomPassword()
     {
-        return substr(md5(uniqid(mt_rand(), true)), 0, 10);
+        return substr(md5(uniqid((string) mt_rand(), true)), 0, 10);
     }
 
     public function resetPassword(User $user)

sources/AppBundle/Controller/Admin/Event/RemoveEventAction.php

@@ -61,7 +61,7 @@ public function __invoke($id, $token)
             return new RedirectResponse($this->urlGenerator->generate('admin_event_list'));
         }
 
-        if ($result->first()['est_supprimable'] !== '1') {
+        if ($result->first()['est_supprimable'] !== 1) {
             $this->flashBag->add('error', 'Impossible de supprimer un évènement utilisé');
             return new RedirectResponse($this->urlGenerator->generate('admin_event_list'));
         }

sources/AppBundle/Controller/Admin/HomeAction.php

@@ -84,7 +84,7 @@ public function __invoke()
                     }
                 }
 
-                $info['statistics']['montant total'] = number_format($montantTotal, 0, 0, ' ') . ' €';
+                $info['statistics']['montant total'] = number_format($montantTotal, 0, ',', ' ') . ' €';
                 $info['url'] = '/pages/administration/index.php?page=forum_inscriptions&id_forum=' . $event->getId();
 
                 $cards[] = $info;

sources/AppBundle/Controller/Admin/LoginAction.php

@@ -38,7 +38,7 @@ public function __invoke(Request $request)
         $lastUsername = $this->authenticationUtils->getLastUsername();
 
         $actualUrl = $request->getSchemeAndHttpHost() . $request->getRequestUri();
-        $targetUri = $request->query->get('target');
+        $targetUri = $request->query->get('target', '');
         $noDomain = parse_url($targetUri, PHP_URL_HOST) === null;
         $targetPath = $targetUri !== $actualUrl && $noDomain ? $targetUri : null;
 

sources/AppBundle/Email/Emails.php

@@ -35,8 +35,7 @@ public function __destruct()
     public function sendInscription(Event $event, MailUser $recipient)
     {
         $mailContent = $event->getMailInscriptionContent();
-
-        if ('' === trim($mailContent)) {
+        if (!$mailContent) {
             throw new InvalidArgumentException("Contenu du mail d'inscription non trouvé pour le forum " . $event->getTitle());
         }
 
@@ -61,7 +60,7 @@ public function sendInscription(Event $event, MailUser $recipient)
 
     private function getAttachementIcsInscription(Event $event, MailUser $recipient)
     {
-        $uid = md5($event->getId());
+        $uid = md5((string) $event->getId());
         $organizerCN = MailUserFactory::afup()->getName();
         $attendeeCN = $recipient->getName();
         $attendeeEmail = $recipient->getEmail();

sources/AppBundle/Event/Ticket/RegistrationsExportGenerator.php

@@ -150,6 +150,9 @@ protected function getFromRegistrationsOnEvent(Event $event)
      */
     private function extractAndCleanTags($comments)
     {
+        if (!$comments) {
+            return null;
+        }
         preg_match('@\<tag\>(.*)\</tags?\>@i', $comments, $matches);
         $tags =  isset($matches[1]) ? $matches[1] : '';
         $tags = explode(';', $tags);

sources/AppBundle/Github/GithubClient.php

@@ -45,7 +45,7 @@ public function getUserInfos($username)
         }
 
         if ($response->getStatusCode() === 200) {
-            return GithubUser::fromApi(json_decode($response->getBody(), true));
+            return GithubUser::fromApi(json_decode($response->getBody()->getContents(), true));
         }
 
         throw new UnableToGetGithubUserInfosException(

sources/AppBundle/Offices/OfficeFinder.php

@@ -202,10 +202,10 @@ private function haversineGreatCircleDistance(
         $latitudeFrom, $longitudeFrom, $latitudeTo, $longitudeTo, $earthRadius = 6371000)
     {
         // convert from degrees to radians
-        $latFrom = deg2rad($latitudeFrom);
-        $lonFrom = deg2rad($longitudeFrom);
-        $latTo = deg2rad($latitudeTo);
-        $lonTo = deg2rad($longitudeTo);
+        $latFrom = deg2rad((float) $latitudeFrom);
+        $lonFrom = deg2rad((float) $longitudeFrom);
+        $latTo = deg2rad((float) $latitudeTo);
+        $lonTo = deg2rad((float) $longitudeTo);
 
         $latDelta = $latTo - $latFrom;
         $lonDelta = $lonTo - $lonFrom;