Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding proxy nodes to the test case #589

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

kevkevinpal
Copy link
Contributor

In this change we're adding the proxy nodes and checking if they are in the nodes file, If they do exsist then we'll try and join the tribe

This will close #584

@kevkevinpal
Copy link
Contributor Author

wtf it should fail for tribeMessages after this commit ea81894

@kevkevinpal
Copy link
Contributor Author

looks to be printing no alias for the proxy nodes, not sure if they're not loading in for some reason

test: typo fix
@kevkevinpal
Copy link
Contributor Author

Only seeing one proxy user being created and put into NODES.json we should at least have two in there

@Evanfeenstra
Copy link
Contributor

we really should have 3 so we can do full test (proxy tribe admin, 2 proxy tribe members, one member can send to another, messages and boost sats)

@kevkevinpal
Copy link
Contributor Author

ok so this might be harder to test than I initially thought, It seems like the function we broke needs multiple users already registered to the proxy before startup. We're registering them as we go on the initialization of the test so they're still connecting

@kevkevinpal
Copy link
Contributor Author

Nonetheless we can still increase the number of proxy users since I think we only had one previously

@kevkevinpal kevkevinpal added the Automated Testing When new test converage needs to be added with no actual modifications to the functionality label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automated Testing When new test converage needs to be added with no actual modifications to the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relay change that broke proxy
2 participants