forked from ReactiveX/rxjs
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(groupBy): fix groupBy to use lift(), supporting composability
Fix bug ReactiveX#1085 in which groupBy was not using lift(). Using lift() is critical to support the ubiquitous lift()-based architecture in RxJS Next. Resolves ReactiveX#1085. BREAKING CHANGES: groupBy() now unsubscribes all inner Observables when the outer Observable is unsubscribed. This diverges from the behavior in RxJS 4, where inner Observables continue even if the outer is unsubscribed.
- Loading branch information
Showing
2 changed files
with
23 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters