Fix nvm installation #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi :) |
|
I'm not sure. That's why I made that big comment :) I assume so though, as long as the base xenial image stays the same. I wonder if there's a better way? |
|
I believe this is now done in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only important change here is line 23,
ENV NVM_DIR /root/.nvm. The old version,ENV NVM_DIR $HOME/.nvmdoesn't work because Docker doesn't recognize $HOME in that context. So, it thinksNVM_DIRis actually/.nvm, which causes that directory to be created and node versions to be installed in there, which messes up the installation.While I was testing this out I moved libsodium earlier in the Dockerfile because it's the lengthiest step and altering the node install shouldn't re-trigger a libsodium build.
I also unnecessarily bumped up the node version, because why not?
If you want I can get rid of these extraneous changes.