Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decrease max number of lookupAddresses params #134

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Nov 25, 2023

🧿 Current issues / What's wrong ?

Current limit of addresses accepted for lookupAddresses is 250. This was a generous arbitrarily number chosen, without any rational.

We're now using graphql API to resolve the addresses, and they have a different limit

💊 Fixes / Solution

Decrease the number of accepted addresses, to match the resolvers API limit

  • Lens limit is 50
  • ENS limit is 1000

🚧 Changes

  • Decrease the limit from 250 to 50 addresses. (this should not have any impact on UI, which is sending addresses in batch of 20)

Copy link
Contributor

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c819ab) 60.35% compared to head (87cf966) 60.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   60.35%   60.35%           
=======================================
  Files          24       24           
  Lines        1077     1077           
  Branches      133      133           
=======================================
  Hits          650      650           
  Misses        422      422           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wa0x6e wa0x6e changed the title fix: decrease max number of lookupAddresses fix: decrease max number of lookupAddresses params Nov 25, 2023
@wa0x6e wa0x6e merged commit 75acdfc into master Nov 25, 2023
4 checks passed
@ChaituVR ChaituVR deleted the decrease-max-lookup-addresses branch November 25, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants