Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split building of .o file from executable #1187

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

WardBrian
Copy link
Member

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Splits the make rule to build executables into two parts. This allows a more natural way to encode #1186, but also allows things like make mymodel.o, which would allow the same sort of thing and speed ups like stan-dev/stanc3#1350

Intended Effect:

How to Verify:

Side Effects:

None

Documentation:

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Contributor

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@WardBrian
Copy link
Member Author

Question for the cmdstanr guys: is KEEP_OBJECT even needed with this, or can you just call make twice (make model.o, make model) to get to where you want?

@andrjohns
Copy link
Contributor

Question for the cmdstanr guys: is KEEP_OBJECT even needed with this, or can you just call make twice (make model.o, make model) to get to where you want?

Mostly it would be nice so that we don't need to change any of the existing code for compiling models. But as you mention it's only a single additional call, so it's not essential

@WardBrian WardBrian merged commit 5bcf7c2 into develop Sep 6, 2023
@WardBrian WardBrian deleted the makefile/split-object-file-build branch September 6, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants