-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when USER_HEADER is not found #1264
Conversation
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
This is very similar to #1217 which added an error message for when the math submodules are not found. This improves the logic around the
USER_HEADER
variable to give an informative error when it is misspecified.Intended Effect:
Using the example from the docs
Before:
After:
How to Verify:
Try the docs example
Side Effects:
This also makes it so that the model will be re-built if only the user header changes, which is great!
Documentation:
None
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: