-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/1029 record fixed param as override #1286
Conversation
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
if we could do something like #1054, then we wouldn't need to do stan-dev/stan#3302 either. |
#1054 requires stan-dev/stan#3071 . The only reason that was blocked is that Michael (betanalpha) thinks zero-dimensional spaces are one-dimensional. I have no intention of continuing to argue with him. I haven't seen him on github or the Stan Forums for a year or two now so I suppose we'd need someone else to review the pull request anyway. If you want me to argue about HMC and zero-dimensional topology with that someone else -- yes, I can do that. |
I believe the pull request was already approved, and I just took a look at it again and it seems fine, so perhaps that is the way to go |
At this point we should replace this with a newer version of #1054, right? |
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
Add logic to the
write_config
method to record whenfixed_param
sampler is used.Intended Effect:
Make it easy to identify StanCSV output files produced by sampler algorithm
fixed_param
, both by humans as well as bystan_csv_reader
.How to Verify:
Unit tests.
Side Effects:
N/A
Documentation:
N/A
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: