Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CmdStan 2.32] Add method laplace_sample #649

Closed
WardBrian opened this issue Jan 19, 2023 · 4 comments · Fixed by #669
Closed

[CmdStan 2.32] Add method laplace_sample #649

WardBrian opened this issue Jan 19, 2023 · 4 comments · Fixed by #669
Labels
feature New feature or request

Comments

@WardBrian
Copy link
Member

See stan-dev/cmdstan#1134

Also added: jacobian flag for optimization.

@WardBrian WardBrian added the feature New feature or request label Jan 19, 2023
@WardBrian WardBrian changed the title [CmdStan 2.32] Add method laplace [CmdStan 2.32] Add method laplace_sample Jan 19, 2023
@WardBrian
Copy link
Member Author

Note: Once argument jacobian is available for optimization, the class CmdStanMLE's name is incorrect

@mitzimorris
Copy link
Member

is there a way to change a class name or introduce a new one while maintaining backwards compatibility?
if so, what is the best new name? CmdStanOPTM ?

@WardBrian
Copy link
Member Author

I think you can do something like

class NewName:
    ... # all logic

class OldName(NewName):
    def __init__(self, *args, **kwargs):
        warnings.warn("Deprecated")
        super().__init__(*args, **kwargs)

@WardBrian
Copy link
Member Author

See CmdStanR design discussion:
stan-dev/cmdstanr#760 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants