-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stan 2.32] Laplace method and other changes #669
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #669 +/- ##
===========================================
- Coverage 80.85% 80.08% -0.78%
===========================================
Files 69 48 -21
Lines 10734 7476 -3258
===========================================
- Hits 8679 5987 -2692
+ Misses 2055 1489 -566 see 39 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@mitzimorris I think this is at the minimum place needed before review. I'd like to merge this before starting on Pathfinder because it streamlines some of the shared code for things like stan_variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good - appreciate extract_reshape
.
the unit tests cover the essential points of failure.
Currently WIP
Submission Checklist
Summary
Closes #649
See stan-dev/cmdstanr#760 (comment) for details
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: