Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stan 2.32] Laplace method and other changes #669

Merged
merged 14 commits into from
Jul 26, 2023
Merged

[Stan 2.32] Laplace method and other changes #669

merged 14 commits into from
Jul 26, 2023

Conversation

WardBrian
Copy link
Member

Currently WIP

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #649

See stan-dev/cmdstanr#760 (comment) for details

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #669 (3514acf) into develop (730742a) will decrease coverage by 0.78%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #669      +/-   ##
===========================================
- Coverage    80.85%   80.08%   -0.78%     
===========================================
  Files           69       48      -21     
  Lines        10734     7476    -3258     
===========================================
- Hits          8679     5987    -2692     
+ Misses        2055     1489     -566     

see 39 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WardBrian WardBrian marked this pull request as ready for review July 25, 2023 16:23
@WardBrian
Copy link
Member Author

@mitzimorris I think this is at the minimum place needed before review. I'd like to merge this before starting on Pathfinder because it streamlines some of the shared code for things like stan_variables

@WardBrian WardBrian requested a review from mitzimorris July 25, 2023 16:31
@WardBrian WardBrian added feature New feature or request help wanted Extra attention is needed labels Jul 25, 2023
Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good - appreciate extract_reshape.

the unit tests cover the essential points of failure.

@WardBrian WardBrian merged commit b1aff80 into develop Jul 26, 2023
@WardBrian WardBrian deleted the stan-2-32 branch July 26, 2023 14:22
@WardBrian WardBrian mentioned this pull request Aug 25, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CmdStan 2.32] Add method laplace_sample
3 participants