[1.0] Remove deprecations

[WardBrian]

Closes #430. This should probably be the last thing we merge before cutting a release, hence the draft status.

Submission Checklist

• Run unit tests
• Declare copyright holder and open-source license: see below

Summary

• Removed all deprecated features

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

• Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)

[WardBrian]

Seems like Pylint has updated again, ugh.

[mitzimorris]

this one: Formatting a regular string which could be a f-string (consider-using-f-string)
keep or ignore?

[WardBrian]

It's good advice in most cases, except for logging (f-strings are greedy evaluated, as opposed to %-formatting). I will check if these warnings include logging statements - if so, we should probably disable it

[WardBrian]

Looking through, they don't include logging statements, so I'd consider them all legit. I can open a separate PR which fixes, it's a lot of minor one-line rewrites

[mitzimorris]

so disable for now, address in separate PR? sounds good to me.
there are close to 300 of these. ugh.

[WardBrian]

Yeah, this is actually a huge pain. f-strings are great (easier to read imo, and also faster by a not-insignificant margin) but they do not play nicely with a short line length limit and long variable names. I'm just going to disable it for now, maybe we fix it one day maybe we don't. Tools like flynt can help with the conversion, but they won't catch all cases and won't do the manual line-splitting we need to satisfy flake8 at 80 characters

[codecov-commenter]

Codecov Report

Merging #460 (78a8e9d) into develop (f048803) will decrease coverage by 0.38%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #460      +/-   ##
===========================================
- Coverage    78.09%   77.71%   -0.39%     
===========================================
  Files           30       20      -10     
  Lines         9255     5976    -3279     
===========================================
- Hits          7228     4644    -2584     
+ Misses        2027     1332     -695     

Impacted Files	Coverage Δ
cmdstanpy/cmdstanpy/model.py	85.75% <0.00%> (-0.89%)	⬇️
...runner/work/cmdstanpy/cmdstanpy/cmdstanpy/model.py	85.75% <0.00%> (-0.89%)	⬇️
cmdstanpy/cmdstanpy/__init__.py	86.95% <0.00%> (-0.55%)	⬇️
...ner/work/cmdstanpy/cmdstanpy/cmdstanpy/__init__.py	86.95% <0.00%> (-0.55%)	⬇️
a/cmdstanpy/cmdstanpy/cmdstanpy/_version.py
a/cmdstanpy/cmdstanpy/cmdstanpy/__init__.py
a/cmdstanpy/cmdstanpy/cmdstanpy/cmdstan_args.py
a/cmdstanpy/cmdstanpy/cmdstanpy/compiler_opts.py
a/cmdstanpy/cmdstanpy/cmdstanpy/model.py
...tanpy/cmdstanpy/cmdstanpy/install_cxx_toolchain.py
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f048803...78a8e9d. Read the comment docs.

[mitzimorris]

LGTM!

[WardBrian]

Merging in anticipation of a 1.0 (possibly a RC first)