Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup empty tests, add --cores argument #470

Merged
merged 4 commits into from
Oct 8, 2021
Merged

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

This does some mypy cleanup following #461. It also closes #467 and closes #466

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #470 (d0b18bc) into develop (832a42d) will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #470      +/-   ##
===========================================
- Coverage    77.87%   77.48%   -0.39%     
===========================================
  Files           30       20      -10     
  Lines         9174     6112    -3062     
===========================================
- Hits          7144     4736    -2408     
+ Misses        2030     1376     -654     
Impacted Files Coverage Δ
cmdstanpy/cmdstanpy/utils.py 69.94% <0.00%> (-0.58%) ⬇️
cmdstanpy/cmdstanpy/install_cmdstan.py 32.15% <0.00%> (-0.13%) ⬇️
...k/cmdstanpy/cmdstanpy/cmdstanpy/install_cmdstan.py 32.15% <0.00%> (-0.13%) ⬇️
...runner/work/cmdstanpy/cmdstanpy/cmdstanpy/utils.py 70.52% <0.00%> (ø)
a/cmdstanpy/cmdstanpy/cmdstanpy/__init__.py
a/cmdstanpy/cmdstanpy/cmdstanpy/utils.py
a/cmdstanpy/cmdstanpy/cmdstanpy/model.py
a/cmdstanpy/cmdstanpy/cmdstanpy/progress.py
a/cmdstanpy/cmdstanpy/cmdstanpy/_version.py
a/cmdstanpy/cmdstanpy/cmdstanpy/cmdstan_args.py
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832a42d...d0b18bc. Read the comment docs.

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cores arg is much needed, ditto cleanup

@mitzimorris mitzimorris merged commit acab458 into develop Oct 8, 2021
@mitzimorris mitzimorris deleted the cleanup-1.0 branch October 11, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "cores" argument to install_cmdstan Clean up test cases
3 participants