Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 1.2.1 #729

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Add release notes for 1.2.1 #729

merged 6 commits into from
Feb 5, 2024

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented Jan 22, 2024

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian linked an issue Jan 22, 2024 that may be closed by this pull request
Copy link
Contributor

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit unclear on the language in the first comment. Otherwise, looks good.

cmdstanpy/model.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46f8608) 79.82% compared to head (c12b9dd) 79.88%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #729      +/-   ##
===========================================
+ Coverage    79.82%   79.88%   +0.06%     
===========================================
  Files           75       50      -25     
  Lines        11502     7666    -3836     
===========================================
- Hits          9181     6124    -3057     
+ Misses        2321     1542     -779     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much clearer. Thanks!

@WardBrian WardBrian marked this pull request as ready for review February 5, 2024 14:56
@WardBrian WardBrian requested a review from mitzimorris February 5, 2024 14:56
@WardBrian
Copy link
Member Author

@mitzimorris I think it would be good to release this week if you have a chance to look over the release notes. Thank you!

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGreatTM!

@WardBrian WardBrian merged commit ef09fa1 into develop Feb 5, 2024
16 checks passed
@WardBrian WardBrian deleted the prep/1.2.1-release-notes branch February 5, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 1.2.1
4 participants