Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dimensions of coefficient matrix #397

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Fix dimensions of coefficient matrix #397

merged 1 commit into from
Sep 13, 2021

Conversation

mgrabovsky
Copy link
Contributor

The dimension of the matrix beta of coefficients in multi-logit regression should be D × K in accord with the initial example, not K × D.

Submission Checklist

  • Builds locally – couldn't get the build system to work
  • Declare copyright holder and open-source license: see below

Summary

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Matěj Grabovský

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There's one change request which is optional as it wasn't an issue introduced intros PR. Please let me know if I should merge or if it'd be OK to fix the definition of beta to be a declare-define.

src/stan-users-guide/regression.Rmd Outdated Show resolved Hide resolved
@mgrabovsky
Copy link
Contributor Author

Thanks for the review. I've made that one change you suggested.

@bob-carpenter
Copy link
Member

Thanks.

The only problem now is that _main.Rmd was inadvertently included. That's a byproduct of bookdown building the docs and not something we want to include in the repo.

The dimension of the matrix `beta` of coefficients in multi-logit
regression should be D × K in accord with the initial example, not
K × D.
@mgrabovsky
Copy link
Contributor Author

Sorry about that. (Perhaps it could be added to the gitignore to prevent such issues in the future?)

Copy link
Member

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@bob-carpenter bob-carpenter merged commit 8fc60f9 into stan-dev:master Sep 13, 2021
@bob-carpenter
Copy link
Member

Yes, I think it makes sense to add it to our gitignore. I created an issue: #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants