Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register internal S3 methods #239

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Register internal S3 methods #239

merged 1 commit into from
Jan 22, 2024

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jan 22, 2024

Adds rogygen export tags to internal S3 methods. These aren't actually exported (just registered). See r-lib/roxygen2#1175.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a69414b) 93.00% compared to head (a16f87e) 93.00%.

❗ Current head a16f87e differs from pull request most recent head ec39aaf. Consider uploading reports for the commit ec39aaf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files          30       30           
  Lines        2788     2788           
=======================================
  Hits         2593     2593           
  Misses        195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgabry jgabry merged commit eed620d into master Jan 22, 2024
6 checks passed
@jgabry jgabry deleted the register-internal-methods branch January 22, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants