-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Jenkins test stages #1789
Conversation
I dropped the ball on this one, but better late then never. Tagging a few people that were interested in this 2 months ago @martinmodrak @serban-nicusor-toptal @syclik @SteveBronder |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
I'm cool with this! The Jenkinsfile looks fine to me, but if @serban-nicusor-catena has any time to take a look at double check it that would be great |
Looks good to me, many thanks for looking into it @rok-cesnovar ! |
Summary
Reorganizes Jenkins stages as suggested here: https://discourse.mc-stan.org/t/bringing-math-testing-time-resources-down/12885/5
The most compute intensive stages are organized as follows:
Reasons:
Tests
Describe the new tests with the pull request.
For bug fixes there should be a new test that would fail if the patch weren't in place (so that the bug could be caught if it comes up again).
For new features there should be at least one test showing the expected behavior and one test that demonstrates error handling. Be aware the reviewer will very likely ask for more tests than this, but it's a start.
Side Effects
/
Checklist
Copyright holder: Rok Češnovar
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested