Bugfix/1839 make shell linux

[mitzimorris]

Summary

Makefile file make/libraries uses the bash shell string matching via operator '[[', but on Linux, the default shell is (sometimes, i.e., on Ubuntu) /bin/sh. Override this by setting make variable SHELL to /bin/bash.

Tests

On Linux, run make commands:

The following sequence of commands should not trigger reported error message from bin/sh (stan-dev/cmdstan#852 (comment))

make print-OS
make print-SHELL
make clean-all
make stan/lib/stan_math/lib/tbb/tbb.def

Verify that make output doesn't contains error message from bin/sh (stan-dev/cmdstan#852 (comment))

Side Effects

Sets make shell to /bin/bash

Release notes

Checklist

• Math issue #(issue number) 1839

• Copyright holder: (fill in copyright holder information)

  The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses: Columbia University
  - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
  - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

• the basic tests are passing

  • unit tests pass (to run, use: ./runTests.py test/unit)
  • header checks pass, (make test-headers)
  • dependencies checks pass, (make test-math-dependencies)
  • docs build, (make doxygen)
  • code passes the built in C++ standards checks (make cpplint)

• the code is written in idiomatic C++ and changes are documented in the doxygen

• the new changes are tested

[rok-cesnovar]

Thank you!

[stan-buildbot]

---

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan	4.87	4.89	1.0	-0.27% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.02	0.02	1.01	1.05% faster
eight_schools/eight_schools.stan	0.1	0.09	1.08	7.22% faster
gp_regr/gp_regr.stan	0.22	0.22	1.01	0.92% faster
irt_2pl/irt_2pl.stan	6.45	6.45	1.0	0.08% faster
performance.compilation	89.49	86.99	1.03	2.79% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	7.53	7.64	0.99	-1.52% slower
pkpd/one_comp_mm_elim_abs.stan	20.33	20.72	0.98	-1.87% slower
sir/sir.stan	93.71	93.53	1.0	0.19% faster
gp_regr/gen_gp_data.stan	0.05	0.05	0.97	-2.61% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.96	2.95	1.0	0.15% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.3	0.3	1.01	0.6% faster
arK/arK.stan	1.73	1.76	0.98	-1.55% slower
arma/arma.stan	0.66	0.66	1.01	0.72% faster
garch/garch.stan	0.52	0.52	1.0	0.15% faster
Mean result: 1.00459831951

---

Jenkins Console Log
Blue Ocean
Commit hash: 5fd9cdc

---

Machine information

ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix