-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New stan syntax and tags #253
Conversation
This reverts commit 70688f0.
I am afraid I won't have the time for full code checking at the moment. Is there something you would like me to take a look at specificially? |
Sorry for my late reply. I updated all the syntax using the stance compiler and checked that all models works to compile and run so I would just skim through quickly and see if you see anything crazy. I also polished the tags based on discussion with aki to formalize that a little more. You can see the keywords here: We have also discussed better ways to assess convergence for reference posteriors (that are less hacky) in: |
I am currently super busy with teaching and grant writing. If you want to merge it this or next week, perhaps already merge without my feedback. Sorry for being so slow with this right now :-( |
No problem @paul-buerkner . Maybe @avehtari could take a quick look if something is missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some edits to md files. It would have been better to use canonicalizer with the option that would have changed only the syntax and not make additional white space changes. Now there were too many files with only white space changes and I didn't have time check changes that matter. If the new code did run and the results did not change, I expect no problems.
The PR includes: