Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stan_clogit: allow outcome to be factor #519

Closed
nlpaces opened this issue May 11, 2021 · 2 comments · Fixed by #520
Closed

stan_clogit: allow outcome to be factor #519

nlpaces opened this issue May 11, 2021 · 2 comments · Fixed by #520

Comments

@nlpaces
Copy link

nlpaces commented May 11, 2021

Summary:

Change acceptable class response variable

Description:

I had assumed that the class of response variable used in the standard clogistic regression function would be accepted in stan_clogit function. clogistic accepts factors. stan_clogit doesn’t. Once I had reformated to numeric, stan_clogit ran without difficulty.

Reproducible Steps:

Message from Jonah:
Good catch! If you want to open an issue at the rstanarm GitHub repo we’ll definitely consider adding support for factors. I think it makes sense to allow them.

RStanARM Version:

2.21.1

R Version:

3.6.3

Operating System:

Ubuntu 18.04.4 LTS

@jgabry
Copy link
Member

jgabry commented May 11, 2021 via email

jgabry added a commit that referenced this issue May 11, 2021
@jgabry jgabry changed the title stan_clogit stan_clogit: allow outcome to be factor May 11, 2021
@jgabry
Copy link
Member

jgabry commented May 11, 2021

This ended up being a really easy fix, so I already have a pull request open: #520. Thanks again for bringing this to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants