Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling is able to initialize when there is an exception in transformed parameters #2570

Merged
merged 10 commits into from
Jul 11, 2018
Merged

Sampling is able to initialize when there is an exception in transformed parameters #2570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae33787
Updating .gitignore
syclik Jul 6, 2018
5960138
updating whitespace
syclik Jul 7, 2018
344f82c
adding failing test for issue #2562
syclik Jul 6, 2018
0e26281
Adding additional test for random_var_context that shows the current …
syclik Jul 6, 2018
b456e0e
Fixes #2562. Updating src/stan/services/util/initialize.hpp to handle…
syclik Jul 7, 2018
f961325
Merge branch 'develop' of github.com:stan-dev/stan into bugfix/issue-…
seantalts Jul 9, 2018
813c89e
adding newline
syclik Jul 10, 2018
055f60f
updating initialization code
syclik Jul 10, 2018
cacf1ff
simplifying logic
syclik Jul 10, 2018
83b3f78
cpplint
syclik Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,5 @@ stan.kdev4

# local make include
/make/local

*.gch
4 changes: 2 additions & 2 deletions src/stan/services/optimize/bfgs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ namespace stan {

std::vector<int> disc_vector;
std::vector<double> cont_vector
= util::initialize(model, init, rng, init_radius, false,
logger, init_writer);
= util::initialize<false>(model, init, rng, init_radius, false,
logger, init_writer);

std::stringstream bfgs_ss;
typedef stan::optimization::BFGSLineSearch
Expand Down
4 changes: 2 additions & 2 deletions src/stan/services/optimize/lbfgs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ namespace stan {

std::vector<int> disc_vector;
std::vector<double> cont_vector
= util::initialize(model, init, rng, init_radius, false,
logger, init_writer);
= util::initialize<false>(model, init, rng, init_radius, false,
logger, init_writer);

std::stringstream lbfgs_ss;
typedef stan::optimization::BFGSLineSearch
Expand Down
4 changes: 2 additions & 2 deletions src/stan/services/optimize/newton.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ namespace stan {

std::vector<int> disc_vector;
std::vector<double> cont_vector
= util::initialize(model, init, rng, init_radius, false,
logger, init_writer);
= util::initialize<false>(model, init, rng, init_radius, false,
logger, init_writer);


double lp(0);
Expand Down
Loading