-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/rvalue and vector scalar deserializer #3043
Fix/rvalue and vector scalar deserializer #3043
Conversation
…ization or vectors of scalars
…4.1 (tags/RELEASE_600/final)
Thanks again! Will let @t4c1 review this one, due to Mac machine issues its unlikely we release before Tuesday anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its great that you fixed it! I just think some of the changes you made are redundant.
…ve std::forward from to_ref() in rvalue() for cases it's not necessary
…m:stan-dev/stan into fix/rvalue-and-vector-scalar-deserializer
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.15.7 BuildVersion: 19H15CPU: G++: Clang: |
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Fixes stan-dev/math#2493 by having
rvalue()
return back references instead of copies for nil index andstd::vector
subsettingIntended Effect
Fixes stan-dev/math#2493
How to Verify
./runTests.py -j28 ./src/test/unit/model/indexing/
Side Effects
Documentation
No new docs
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Steve Bronder
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: