Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new get_param_names bool arguments in initialize #3138

Closed
wants to merge 2 commits into from

Conversation

SteveBronder
Copy link
Collaborator

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Uses stan-dev/stanc3#1241 to get back only the parameter names when setting initial values, Fixes stan-dev/stanc3#1240 so that when the user specifies initial values they are only run once.

This PR will fail until stan-dev/stanc3#1241 is merged

Intended Effect

Fixes stan-dev/stanc3#1240

How to Verify

Do I need additional tests for this? I'm not sure what kind of test we would want.

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Steve Bronder

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian
Copy link
Member

Oh, I put together #3139 to do the same thing.

These need to be arguments to the existing function, not a new overload, or else model.get_param_names(vec) becomes ambiguous and fails to compile

@WardBrian
Copy link
Member

Subsumed by #3139

@WardBrian WardBrian closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] get_param_names should be able to only return object names in parameters block
3 participants