Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: using SUNDIALS_TARGETS instead of LIBSUNDIALS #3162

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

syclik
Copy link
Member

@syclik syclik commented Feb 7, 2023

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Updates the make build process to use the SUNDIALS_TARGETS variable instead of the current LIBSUNDIALS.

This has no user-facing effects.

For context: stan-dev/math#2861.

Intended Effect

More consistent use of Stan Math's makefiles.

How to Verify

Everything should work as-is.

Side Effects

None.

Documentation

None necessary. This doesn't change anything for the user.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Daniel Lee

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@syclik syclik added the build label Feb 7, 2023
@syclik syclik requested a review from WardBrian February 7, 2023 19:05
Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is it fine to manually update the submodule rather than wait for the math CI to do it for us?

@WardBrian WardBrian merged commit c86bcbe into develop Mar 23, 2023
@WardBrian WardBrian deleted the feature/libsundials branch March 23, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants