Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always discard at least 1 entry in new RNGs #3168

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented Feb 24, 2023

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

This makes it so at least 1 entry is discarded from new RNG instances, even when chain == 0

Intended Effect

Closes #3167

How to Verify

See https://godbolt.org/z/G953v67c4 and the model/code provided in #3167

Side Effects

RNG seeds from previous versions of Stan will have different behavior for chain_id 0 and in the transformed data block. Users who did not use _rng functions in transformed data or manually set their chain id to 0 will not observe different behavior.

Documentation

None

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@bob-carpenter bob-carpenter merged commit c9060b9 into develop Feb 24, 2023
@WardBrian WardBrian deleted the fix/3167-always-discard-create-rng branch April 8, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_rng with chain=0 appears to return biased first draw
3 participants