Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax requirements for 0-sized data objects in JSON #3170

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Follow on to #3165, this allows for any variable name to be "validated" if the expected size is 0.

Intended Effect

This is necessary because

{ "foo" : [] }

is a valid JSON for array[0] tuple(real, real) foo, but the Stan compiler will request information on "foo.1" and "foo.2" which don't exist.

How to Verify

Tests were added

Side Effects

If an object has a 0 dimension (e.g. is size 0), then it is technically no longer required to be in the JSON at all. E.g., for matrix[0, 3] bar, valid JSONs are now { "bar" : [] }, { "bar" : [[]] }, and simply { }

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian requested a review from mitzimorris March 8, 2023 21:18
@WardBrian WardBrian requested a review from rok-cesnovar March 17, 2023 13:58
Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an object has a 0 dimension (e.g. is size 0), then it is technically no longer required to be in the JSON at all

🕺🏻

@WardBrian WardBrian merged commit 4ec109a into develop Mar 17, 2023
@WardBrian WardBrian deleted the feature/loosen-empty-json-checks branch March 17, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants