Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stan::test::is_valid_JSON consistently #3232

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Follow up on #3230, uses the new utility function in a couple places we were directly using RapidJSON for testing

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I think we could do similar cleanup in CmdStan.

@WardBrian
Copy link
Member Author

Yes, I have one I’m working on

@WardBrian WardBrian merged commit 342b657 into develop Sep 22, 2023
2 checks passed
@WardBrian WardBrian deleted the test/use-json-test-util branch September 22, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants