update psis to not add back the max and return the unnormalized resample ratios #3243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3241 by just removing the line that adds back the max log likelihood ratio
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Intended Effect
How to Verify
Should we have tests for this? This just seemed like a numeric bug inside of the function so I'm not sure if / how to test this
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Flatiron Institute
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: