Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Avoid hardcoding boost::ecuyer1988 #3263

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented Jan 30, 2024

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

This is the first part of #3256. After this, we can update the signatures in stanc3 to use stan::rng_t, which will allow us to change what is used underlyingly without breaking all our CI.

Intended Effect

Avoid using the name boost::ecuyer1988 directly. We refer to it by an alias stan::rng_t, which allows the underlying type to be more easily changed in the future.

How to Verify

Side Effects

None

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian changed the title Refactor: Switch default RNG to boost::mixmax Refactor: Avoid hardcoding boost::ecuyer1988 Jan 30, 2024
@WardBrian WardBrian marked this pull request as ready for review January 30, 2024 17:53
@WardBrian
Copy link
Member Author

Ok, my proposed order of merges is:

  1. Merge this, which has no semantic changes, just some new typenames.
  2. Merge Avoid hardcoding boost::ecuyer1988 stanc3#1395 which uses those typenames
  3. Open a PR from https://github.com/stan-dev/stan/tree/refactor/actually-switch-rngs which actually switches to mixmax

Copy link
Collaborator

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@WardBrian WardBrian merged commit 476a356 into develop Jan 31, 2024
3 checks passed
@WardBrian WardBrian deleted the refactor/switch-rngs branch January 31, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants