Add flags to get_dims and get_param_names #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently running this against stan-dev/stan#3139 I am also going to run stan-dev/stan#3139 against the binaries from this branch. If those tests all pass, I think we should merge both PRs. If we don't want to go down this route we should revert #1241 and decide how to proceed. |
WardBrian
changed the title
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #1245 +/- ##
==========================================
+ Coverage 88.95% 88.98% +0.02%
==========================================
Files 64 64
Lines 9710 9734 +24
==========================================
+ Hits 8638 8662 +24
Misses 1072 1072
|
|
This and stan-dev/stan#3139 are now passing against each other. The merge order will need to be: Merge stan-dev/stan#3139, which will fail Merge this, wait for build to upload nightly binary Re-run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #1241.
As discussed in stan-dev/stan#3139, updating an existing model_base method is sort of chicken-egg. This PR will fail as long as
stanhas the older definition of model_base, butstanwill fail as long as we're generating two ambiguous definitions in the models (not all of the Stan code that needs access to the model uses model_base as the interface, it seems)Submission Checklist
Release notes
Remove old version of
get_param_namesafter #1241Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)