-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sum_to_zero transform #1443
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1443 +/- ##
==========================================
- Coverage 89.52% 89.49% -0.03%
==========================================
Files 63 63
Lines 10614 10618 +4
==========================================
+ Hits 9502 9503 +1
- Misses 1112 1115 +3
|
The original issue asks for |
@bob-carpenter listed these for consideration in an email with me before implementation work began
I don't have that strong of a preference, but I do think sum_to_zero is more self explanatory without being that much longer |
I like |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Draft because it relies on stan-dev/stan#3308 and one of stan-dev/math#3099 stan-dev/math#3101Submission Checklist
Release notes
Added the
sum_to_zero
transform for vector types.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)