-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prost, tonic, and the generated files #29
Conversation
I'm pretty stumped by the CI failure here. I can't reproduce it locally, and clearly axum 0.6 exists... |
tonic 0.8 depends on axum 0.5, while tonic 0.9 uses axum 0.6. The lock file has tonic 0.8 and axum 0.6, which are incompatible -- maybe a result of some mixups while iterating on versions? I think a |
Hm, tonic 0.9 is causing a failed test ("Error, message length too large: found 10000520 bytes, the limit is: 4194304 bytes"), but also from here it seems like tonic 0.8 should use axum 0.6. |
oh tonic 0.8.2 uses axum 0.5, 0.8.3 uses 0.6. maybe that was the mixup?
which test? |
|
It's probably this. |
ah yeah. others have run into this, looks like 10MB is the limit pubsub set GoogleCloudPlatform/pubsub#164 |
Ok, tonic is bumped to 0.9, and I put the pubsub size at 10MB. I made the bigtable size unlimited because I couldn't find a documented limit. (Pre-tonic 0.9 it was unlimited anyway, so this keeps the old behavior.) Tonic-build 0.9 seems to assume edition 2021, so I also bumped the edition (which required no other changes). Finally, I bumped the MSRV to 1.63 because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is the main breaking-change part of #20, so I figured it was worth separating out.