Allow setting globals of restricted cjs variables.

standard-things · Mar 23, 2019 · 86123b5 · 86123b5
1 parent 876f043
commit 86123b5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/runtime.js b/src/runtime.js
@@ -397,7 +397,13 @@ const Runtime = {
     throw new ERR_CONST_ASSIGNMENT(throwConstAssignment)
   },
   throwUndeclared: function throwUndeclared(name) {
-    throw new ERR_UNDEFINED_IDENTIFIER(name, throwUndeclared)
+    const { unsafeGlobal } = shared
+
+    if (! Reflect.has(unsafeGlobal, name)) {
+      throw new ERR_UNDEFINED_IDENTIFIER(name, throwUndeclared)
+    }
+
+    return unsafeGlobal[name]
   },
   updateBindings(valueToPassThrough) {
     this.entry.updateBindings(null, UPDATE_TYPE_LIVE)

diff --git a/src/visitor/undeclared.js b/src/visitor/undeclared.js
@@ -47,10 +47,7 @@ function init() {
       if (parent.type === "UnaryExpression" &&
           parent.operator === "typeof") {
         this.transforms |= TRANSFORMS_UNDECLARED
-
-        // Use `runtimeName` as the voided expression for content sniffing
-        // based on the presence of the runtime identifier.
-        overwrite(this, node.start, node.end, "void " + runtimeName)
+        overwrite(this, node.start, node.end, runtimeName + ".g." + name)
         return
       }