Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

v0.22.0 was the last version to work in electron 1.8.x #333

Closed
jsg2021 opened this issue Mar 28, 2018 · 4 comments
Closed

v0.22.0 was the last version to work in electron 1.8.x #333

jsg2021 opened this issue Mar 28, 2018 · 4 comments
Labels

Comments

@jsg2021
Copy link
Contributor

jsg2021 commented Mar 28, 2018

Tried updating some dependencies today, and electron won't start with 0.23+... I'm trying to follow the init but electron is crashing when I try to inspect

@jdalton
Copy link
Member

jdalton commented Mar 29, 2018

Hi @jsg2021!

Have you tried esm?
Could you reproduce the issue with a minimum repro of esm + a simple hello world app.

Update:

Ok, I have it fixed locally. I'll publish it tonight!

@jsg2021
Copy link
Contributor Author

jsg2021 commented Mar 29, 2018

Thanks! Sorry i didn’t publish a repro. I’ll make sure to do that next time.

@jdalton
Copy link
Member

jdalton commented Mar 29, 2018

No problem! Thanks for hammering on it!

Update:

v3.0.13 was released 🎉

Update:

While I fixed the fail I didn't fix Electron patching Module._resolveFilename just right, so I'll follow-up in the morning with a more-proper patch (should make things work with import too).

Update:

Patched d5ac29e.

v3.0.14 is released 🎉

@jdalton jdalton added the bug label Mar 29, 2018
jdalton added a commit that referenced this issue Mar 29, 2018
@jsg2021
Copy link
Contributor Author

jsg2021 commented Mar 29, 2018

awesome thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants