Skip to content
This repository was archived by the owner on Nov 4, 2024. It is now read-only.

Not working with pnpm #514

Closed
vjpr opened this issue Jul 21, 2018 · 2 comments
Closed

Not working with pnpm #514

vjpr opened this issue Jul 21, 2018 · 2 comments

Comments

@vjpr
Copy link

vjpr commented Jul 21, 2018

node -v = v8.9.0

See https://github.com/vjpr/issue-esm-pnpm

node -r esm index.js
{ request: 'is-regexp',
  parent: Module {
     children: [],
     exports: {},
     filename: '/Users/Vaughan/dev-scratch/node_modules/stringify-object/index.js',
     id: '/Users/Vaughan/dev-scratch/node_modules/stringify-object/index.js',
     loaded: false,
     parent: undefined,
     paths: [ '/Users/Vaughan/dev-scratch/node_modules/stringify-object/node_modules',
        '/Users/Vaughan/dev-scratch/node_modules',
        '/Users/Vaughan/node_modules',
        '/Users/node_modules',
        '/node_modules' ] } }
/Users/Vaughan/dev-scratch/esm-pnpm-issue/node_modules/.registry.npmjs.org/esm/3.0.72/node_modules/esm/esm.js:1
Error: Cannot find module 'is-regexp'
    at Proxy.<anonymous> (/Users/Vaughan/dev-scratch/esm-pnpm-issue/node_modules/.registry.npmjs.org/esm/3.0.72/node_modules/esm/esm.js:1)
    at Proxy.require.Module._resolveFilename (/Users/Vaughan/dev-scratch/esm-pnpm-issue/index.js:9:39)
    at Proxy.<anonymous> (/Users/Vaughan/dev-scratch/esm-pnpm-issue/node_modules/.registry.npmjs.org/esm/3.0.72/node_modules/esm/esm.js:1)
    at Object.<anonymous> (/Users/Vaughan/dev-scratch/esm-pnpm-issue/node_modules/.registry.npmjs.org/esm/3.0.72/node_modules/esm/esm.js:1)
    at Object.t (/Users/Vaughan/dev-scratch/esm-pnpm-issue/node_modules/.registry.npmjs.org/esm/3.0.72/node_modules/esm/esm.js:1)
    at o (/Users/Vaughan/dev-scratch/esm-pnpm-issue/node_modules/.registry.npmjs.org/esm/3.0.72/node_modules/esm/esm.js:1)
    at Object.<anonymous> (/Users/Vaughan/dev-scratch/node_modules/stringify-object/index.js:2:18)
    at Object.<anonymous> (/Users/Vaughan/dev-scratch/esm-pnpm-issue/node_modules/.registry.npmjs.org/esm/3.0.72/node_modules/esm/esm.js:1)
    at xu (/Users/Vaughan/dev-scratch/esm-pnpm-issue/node_modules/.registry.npmjs.org/esm/3.0.72/node_modules/esm/esm.js:1)
    at /Users/Vaughan/dev-scratch/esm-pnpm-issue/node_modules/.registry.npmjs.org/esm/3.0.72/node_modules/esm/esm.js:1
@dnalborczyk
Copy link
Contributor

dnalborczyk commented Jul 21, 2018

thank you for the bug report @vjpr !

it looks like esm has problems with symlinks.

@jdalton in order for the repro to succeed (or, should I say successfully fail), it is paramount to install the dependencies as the issue title suggests with pnpm.

https://pnpm.js.org/docs/en/installation.html

npm i -g pnpm
pnpm i
node -r esm main.mjs

@jdalton
Copy link
Member

jdalton commented Jul 22, 2018

Thanks @vjpr! (and @dnalborczyk!)

The issue was around resolving hard-links.
I'll try to come up with a test for that.

Update:

v3.0.73 is released 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants