Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Sourcemaps stopped working on latest chrome #756

Closed
cjh9 opened this issue Mar 16, 2019 · 5 comments
Closed

Sourcemaps stopped working on latest chrome #756

cjh9 opened this issue Mar 16, 2019 · 5 comments
Labels

Comments

@cjh9
Copy link

cjh9 commented Mar 16, 2019

Hi, I have been using esm for half a year for a node project, it has been working really great. But just recently the sourcemaps stopped working, I think that it had to do with chrome being updated.

I've created a repro repo

https://github.com/cjh9/esm-sourcemaps-broken/

So basically I can see the raw file main.js and test.js but when I try to put a breakpoint I get redirected to an empty file. Also I tried to turn off the sourcemaps with

ESM_OPTIONS={'cjs':{'paths':true},'sourceMap':false} NODE_PATH=./ node --inspect -r esm main.js

but the inline sourcemaps are still there...

@jdalton
Copy link
Member

jdalton commented Mar 16, 2019

Hi @cjh9!

Yep, it's a Chrome bug. I filed Chromium bug #941035.
(Please sign-in and ⭐️ it.)

They said, it looks related to Chromium bug #941697 too.

@jdalton jdalton closed this as completed Mar 16, 2019
@cjh9
Copy link
Author

cjh9 commented Mar 18, 2019

Thanks @jdalton, but what about turning off the sourcemaps and debug in the raw code? Is it the correct way to specify the sourceMap option like this, ESM_OPTIONS={'cjs':{'paths':true},'sourceMap':false} NODE_PATH=./ node --inspect -r esm main.js?

When I run it like this I still get the inline sourcemap-string at the bottom of the file...

@jdalton
Copy link
Member

jdalton commented Mar 18, 2019

At the moment --inspect trumps the sourceMap option.
Let me change that to respect a value of false.

Update:

Patch 8558ba7;

Update:

esm v3.2.19 is released 🎉

@cjh9

This comment has been minimized.

@jdalton
Copy link
Member

jdalton commented Mar 18, 2019

@cjh9

You should file another bug on them to make that more clear too.
Please post a link here if/when you do

Update:

It looks like the fix to Chromium bug #941697 fixed the Chromium bug #941035 I filed in latest Canary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants