-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SyntaxError with public and private static class fields in node.js v12 #801
Comments
static props is a companion proposal to the class fields proposal. |
yeah, that could be. although both are supported by V8 and node.js v12 (commonjs) without a flag. the reference to #800 was just that I tried to look into it (but it was working just fine), and while I was at it, I tried static (pub+priv) as well to be sure. on a different note, I wonder if it would be easier/better to use the acorn plugins instead (for anything stage 3 (bigint, class fields, static, etc. )? essentially those: "acorn-dynamic-import"
"acorn-import-meta"
"acorn-bigint"
"acorn-class-fields"
"acorn-static-class-features"
"acorn-private-methods" // maybe not, since not in V8, node.js yet
"acorn-export-ns-from" update:
|
Naw, I find their plugins lacking in areas or overly strict in others. Rolling our own provides a balance better suited for |
was just trying to look into: #800
node v12.1.0
esm: 3.2.22
repro:
also tested latest master with #787 and 3c50b83 but same result.
The text was updated successfully, but these errors were encountered: