In prepareValue, guard debug check against null property access

[mk-pmb]

Fixes #748

It probably just masks the real problem, whatever that might be. For now this makes nodemjs work again, you can still add better tracing later.

Considering how often you use Loader.state.package.default.options.debug, it might be worth a guarding helper function.

[jdalton]

Thank you @mk-pmb!

Yes, Loader.state.package.default should be set by then. Are you using esm through node -r esm or through require("esm")(module)?

[mk-pmb]

the 2nd, stdEsm = require('esm') … stdEsm(bridgeModule, …)

[jdalton]

Great! I think I've spotted the issue. I'll prepare build of esm/esm/loader.js for you to swap out.

Update:

Okay! You can either build from our master branch or use loader.js.zip.

[mk-pmb]

Looks like no. :-(
I switched to 3.2.12 and replaced /home/ci-test/lib/node_modules/esm/esm/loader.js with your new one (SHA-1 099c30ebf88f4506bd7da17eafa6bea7f6d414c3): still fails with Cannot read property 'options' of null.
Then I built from master (c07d4ad), same result.

I'll try and extend the esmod-pmb test so you can test it automatically.

[jdalton]

Hmm OK. I'll add the guard then.

Update:

Can you try from our master branch again? You'll have to force update since I force pushed.

[mk-pmb]

Works with current master. 👍

[jdalton]

esm v3.2.18 is released 🎉