This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Entry.initialize(): detect properTime #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `npm pack`ed modules, the mtime is ancient and so we use ctime instead
michaelfig
changed the title
|
@jdalton Here's the PR! |
|
Thank you @michaelfig! |
You're welcome! @jdalton Can you please cut an NPM release with this change included? I notice that |
I can do a forked NPM release (different package name) if you're too busy to do a proper one, but I'd prefer not to. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
npm packed modules, the mtime is ancient and so we use ctime insteadAs discussed in #746 (comment)