feat!: Switch to flat config format #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
69 tasks
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
|
No problem. If you run into any issues, please reach out. |
mightyiam
reviewed
Aug 16, 2023
eslint.config.js
Outdated
| promise, | ||
| import: importPlugin | ||
| } | ||
| }, |
There was a problem hiding this comment.
@nzakas why are the plugins in an object of their own, please?
mightyiam
reviewed
Aug 16, 2023
eslint.config.js
Outdated
| const promise = require('eslint-plugin-promise') | ||
| const globals = require('globals') | ||
|
|
||
| module.exports = [ |
There was a problem hiding this comment.
Is it normal that a flat-config shareable config exports an array? Is it desirable?
|
This isn't working yet. @nzakas feel free to amend this. |
mightyiam
force-pushed
the
flat-config
branch
5 times, most recently
from
40164f2 to
e86b58c
Compare
BREAKING CHANGE: this package now exports a flat config format See readme for example usage. See here for more information: https://eslint.org/docs/latest/use/configure/configuration-files-new Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
|
🎉 Congrats on getting your first pull request landed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are switching to a new config system in ESLint, we are also going around and helping popular packages update to the new format. This PR switches
eslint-config-standardover to the new flat config format.This is a breaking change. If you merge this, people will not be able to use this package in the
extendsfield of eslintrc config files. They'll only be able to use it with flat config. I'm not sure how frequently the config changes, but something to consider before merging.