Merge pull request #25 from delaguilaluis/allow-undefined-in-errbacks

Allow undefined in the first position of callbacks
standard · Apr 16, 2018 · f0bc288 · f0bc288
2 parents a2f6742 + 7ce136a
commit f0bc288
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/rules/no-callback-literal.js b/rules/no-callback-literal.js
@@ -64,14 +64,10 @@ module.exports = {
 
       CallExpression: function (node) {
         var errorArg = node.arguments[0]
-        if (errorArg && isCallback(node.callee.name)) {
-          if (!couldBeError(errorArg)) {
-            context.report(node, 'Unexpected literal in error position of callback.')
-          } else if (node.arguments.length > 1 && errorArg.type === 'Identifier') {
-            if (errorArg.name === 'undefined') {
-              context.report(node, 'Expected "null" instead of "undefined" in error position of callback.')
-            }
-          }
+        var calleeName = node.callee.name
+
+        if (errorArg && !couldBeError(errorArg) && isCallback(calleeName)) {
+          context.report(node, 'Unexpected literal in error position of callback.')
         }
       }
     }